[Bug fix] SegFault when a variable that is part of a derived expression doesn't have data #4394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anagainaru
force-pushed
the
derivedNoData
branch
from
e37112a
to
7eccd3b
Compare
eisenhauer
requested changes
Nov 6, 2024
eisenhauer
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were checking if a variable was defined before allowing the derived variables to be defined but we were not checking correctly if there is data written in a given step for all the variables needed by the derived expression. Before this fix the code was seg faulting.
I added a test for what happens when we try to define a derived variable before we define the component variables and what happens when there's no data to compute the derived variable.